Change auto deployment to use GitHub actions#127
Merged
Conversation
SimonFrings
force-pushed
the
auto_deployment
branch
4 times, most recently
from
74b5b19 to
65ad787
Compare
clue
reviewed
Nov 25, 2022
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Changes LGTM, does it make sense to add a badge to show last deployment date for this branch? 👍
Contributor
Author
|
@clue, I think you're right, I'll add this to my PR 👍 |
SimonFrings
force-pushed
the
auto_deployment
branch
from
65ad787 to
e26e838
Compare
clue
approved these changes
Nov 28, 2022
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for the update, changes LGTM! 
SimonFrings
force-pushed
the
auto_deployment
branch
from
e26e838 to
406aa5b
Compare
Contributor
Author
|
Also added a CI badge :D |
SimonFrings
force-pushed
the
auto_deployment
branch
from
406aa5b to
fcd335b
Compare
clue
requested changes
Nov 28, 2022
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
Please review the badge URL and use the current format.
SimonFrings
force-pushed
the
auto_deployment
branch
from
fcd335b to
3536233
Compare
Contributor
Author
|
@clue This should be the right one |
clue
approved these changes
Nov 28, 2022
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for the update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs reactphp/website#53 and clue/framework-x-website#7.
Builds on top of #125 and #126