Merged
Conversation
clue
reviewed
Apr 21, 2022
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thank you for looking into this, this looks like a nice addition! 👍
docs/api/response.md
Outdated
| crawler receives a redirect, they will automatically follow the new URL provided | ||
| in the `Location` header. | ||
|
|
||
| See [response status codes](#status-codes) for more details. |
Owner
There was a problem hiding this comment.
Definitely a useful link, but perhaps we can make this more useful by providing more context, e.g. a list of common status codes for redirects?
Contributor
Author
There was a problem hiding this comment.
I added a list with commonly used redirect status codes, WDYT?
clue
approved these changes
Apr 29, 2022
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thank you for the update, keep it up! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #13 and #114.