Add signal handling support for SIGINT and SIGTERM#150
Merged
SimonFrings merged 2 commits intoclue:mainfrom Apr 20, 2022
Merged
Add signal handling support for SIGINT and SIGTERM#150SimonFrings merged 2 commits intoclue:mainfrom
SIGINT and SIGTERM#150SimonFrings merged 2 commits intoclue:mainfrom
Conversation
SimonFrings
approved these changes
Apr 20, 2022
|
Nice ! I just did: git checkout main
git pull
git checkout feat/use-nix
git rebase main
git push origin --forceAnd the Nix and Docker images were updated ! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset adds signal handling support for
SIGINTandSIGTERM.Updating the
Dockerfileinstructions to take advantage of this in Docker containers is left up for a follow-up PR once this PR and #149 are merged.As discussed in #144
Refs #149 and #136 as this improves Docker support somewhat, in particular because
docker stopwill send aSIGTERMby defaultRefs #128 as the implementation is in contrast to the fiber compatibility mode that tries to keep the loop running by restarting it automatically