Improve performance by skipping AccessLogHandler if it writes to /dev/null#248
Merged
SimonFrings merged 2 commits intoclue:mainfrom Mar 4, 2024
Merged
Improve performance by skipping AccessLogHandler if it writes to /dev/null#248SimonFrings merged 2 commits intoclue:mainfrom
AccessLogHandler if it writes to /dev/null#248SimonFrings merged 2 commits intoclue:mainfrom
Conversation
SimonFrings
reviewed
Mar 4, 2024
Contributor
SimonFrings
left a comment
There was a problem hiding this comment.
Nit: Just noticed two typos in test names
SimonFrings
approved these changes
Mar 4, 2024
Contributor
SimonFrings
left a comment
There was a problem hiding this comment.
Nice, pull request looks good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset improves performance noticeable by skipping the
AccessLogHandlerif it writes to/dev/null. This is commonly used when the access log is not needed, such as when running behind a reverse proxy or when benchmarking the raw application performance.This can be easily reproduced by running a benchmark against any of the examples like this:
(Also posted in https://twitter.com/another_clue/status/1764649661749690540)
This builds on top of the recent access log path additions from #247. In particular, this optimization works both when explicitly configured to log to
/dev/nullor when implicitly logging to console output that is piped to/dev/null.This is a pure performance optimization that comes with 100% code coverage and does not otherwise affect the public API, so it should be safe to apply. This currently focuses on Unix-based platforms (Linux / Mac) as the main deployment target, but similar optimizations should be possible on Windows (using
nulinstead of/dev/null).You're looking at several days worth of work, especially for testing this across multiple platforms. If you enjoy this change and want to help us continue to ship more improvements, consider supporting this project, for example by becoming a sponsor ❤️
Builds on top of #247
Refs #169