Show empty response body size in access log when response body MUST be empty#50
Merged
SimonFrings merged 1 commit intomainfrom Nov 5, 2021
log-no-body
Merged
Show empty response body size in access log when response body MUST be empty#50SimonFrings merged 1 commit intomainfrom log-no-body
SimonFrings merged 1 commit intomainfrom
log-no-body
Conversation
SimonFrings
approved these changes
Nov 5, 2021
This was referenced Nov 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset ensures we always log an empty response body size in the access log when the response body MUST be empty, such as for
HEADrequests,204 No Contentand304 Not Modified.Builds on top of #45, #46, #47, #48, #49
Refs reactphp/http#429