Merged
Conversation
yadaiio
changed the title
yadaiio
changed the title
SimonFrings
suggested changes
Jan 26, 2024
Contributor
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
Thanks for updating this PR, added a few remarks below 👍
These changes look similar to clue/reactphp-sqlite#43, maybe include a reference to this ticket in your description and update the title?
yadaiio
changed the title
Contributor
Author
|
Thank you @SimonFrings for informing me about this. Changes should be okay by now, I also changed the title of this pull request and added the references. Thank you 👍 |
This was referenced Jan 30, 2024
This was referenced Feb 9, 2024
This was referenced Mar 19, 2024
This was referenced Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a few typos with the help of https://github.com/szepeviktor/typos-on-you.
Builds on top of: clue/reactphp-sqlite#43.