Skip to content

Conversation

@joaomoura24
Copy link
Collaborator

@joaomoura24 joaomoura24 commented Dec 23, 2024

Description

Describe the additions made in this pull request.

Todo

  • Completed implementation of new feature.
  • Add unit-test for the new feature.
  • Add documentation for the new feature.
  • Ensure all unit tests pass.
  • Address all issues raised by unit-tests.
  • Consider adding an example that demonstrates the use of the new feature (not always necessary).
  • Added code reviewer.

@joaomoura24 joaomoura24 requested a review from cmower December 23, 2024 21:37
@cmower
Copy link
Owner

cmower commented Dec 26, 2024

Thanks @joaomoura24! The tests for ubuntu/python 3.7 are failing. I suggest either fix the issue or drop support for ubuntu/python3.7 all together.

@joaomoura24
Copy link
Collaborator Author

Hi @cmower. Adding a conditional requirement seems to solve the issue of working for python 3.7.
To minimise work, while merging we can squash the two commits into one.

@joaomoura24
Copy link
Collaborator Author

@cmower, can I merge this pull request? I might need to create another fix_... branch from the master.

@cmower
Copy link
Owner

cmower commented Jan 6, 2025

@joaomoura24 happy for you to merge! Thanks

@joaomoura24 joaomoura24 merged commit 3ebd9ef into cmower:master Jan 6, 2025
10 checks passed
@joaomoura24 joaomoura24 deleted the fix_pip_install_dot branch January 6, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants