Security Bug - Privilege escalation attack #211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There exists a security issue where any user on the system can obtain root privileges, because isolate is vulnerable to a privilege escalation attack.
The default setup installs isolate with the permissions of 4755, so any user can execute isolate and perform this attack. A corresponding pull request for MOE is at bblackham/moe-cms#3. A demonstration of how it might be performed (without actually performing it), is at https://github.com/ronalchn/isolate-cheater, in the test which uses
system-cronjob-writer/main.cpp.To protect your system against the attack immediately, you can do one of the following:
Note that any old copy of the isolate executable can be used as an attack vector - check to see if any old versions are used
isolate: Update from NZOI/moe-cms@ee98549