Skip to content

Comments

Allowing import and py3 compatabillity#1

Open
borgr wants to merge 9 commits intocnap:masterfrom
borgr:master
Open

Allowing import and py3 compatabillity#1
borgr wants to merge 9 commits intocnap:masterfrom
borgr:master

Conversation

@borgr
Copy link

@borgr borgr commented Dec 17, 2017

Hi,
The changes are not large and only affect the code (nothing in the logic is changed).

  1. fixed a bug of not closing files
  2. allowed to be run on py3
  3. moved the main calculation into a function from main so import would be possible
  4. PEP08
  5. historical typo (BLEU instead of GLEU)
  6. the name of the project is not so great at '-' can't be a part of a python module name, I would change it into a '_' if I were you, but its up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant