Merged
Conversation
Member
|
Thanks for this @dwelsch-esi, I've removed the |
chalin
reviewed
Feb 25, 2025
Collaborator
chalin
left a comment
chalin
left a comment
There was a problem hiding this comment.
Thanks for these updates @dwelsch-esi. See inline for a few initial comments. I'll provide more later, but could you first rebase from main at HEAD, and ensure that all checks are passing?
Signed-off-by: Dave Welsch <dwelsch@expertsupport.com>
… CNCF doc analyses. Signed-off-by: Dave Welsch <dwelsch@expertsupport.com>
Signed-off-by: Nate W <natew@cncf.io>
chalin
force-pushed
the
criteria-update-1
branch
from
7461f99 to
3784d9b
Compare
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
chalin
reviewed
Feb 25, 2025
chalin
reviewed
Feb 25, 2025
chalin
reviewed
Feb 25, 2025
chalin
reviewed
Feb 25, 2025
docs/analysis/criteria.md
Outdated
|
|
||
| - Is your website accessible via HTTPS? | ||
| - Does HTTP access, if any, redirect to HTTPS? | ||
| - Are links to external websites or applications working and current? |
Collaborator
There was a problem hiding this comment.
Good addition! Actually, we want to know if links (be they internal or external) are valid.
Collaborator
|
Hurray, file format and link checking are passing! We can address the markdown linter issues after the other prose comments have been addressed IMHO. |
Co-authored-by: Dave Welsch <dwelsch@expertsupport.com> Co-authored-by: Nate W <natew@cncf.io> Signed-off-by: Nate W <natew@cncf.io>
Signed-off-by: Nate W <natew@cncf.io>
nate-double-u
approved these changes
Feb 26, 2025
Member
nate-double-u
left a comment
nate-double-u
left a comment
There was a problem hiding this comment.
Thanks for this @dwelsch-esi!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update criteria to include common findings from the last two years of CNCF doc analyses.