Enable build of ch32fun and minichlink on FreeBSD#790
Enable build of ch32fun and minichlink on FreeBSD#790adventureloop wants to merge 2 commits intocnlohr:masterfrom
Conversation
| ifneq ($(shell $(WHICH) riscv64-unknown-elf-gcc 2>$(NULLDEV)),) | ||
| PREFIX_DEFAULT:=riscv64-unknown-elf | ||
| else ifneq ($(shell $(WHICH) riscv32-unknown-elf-gcc 2>$(NULLDEV)),) | ||
| PREFIX_DEFAULT:=riscv32-unknown-elf |
|
|
||
| clangd : | ||
| make clean | ||
| $(MAKE) clean |
There was a problem hiding this comment.
Can you put a MAKE?=make earlier? so on old Windows Make versions it still works?
|
|
||
| minichlink : $(C_S) $(H_S) Makefile | ||
| gcc -o $@ $(C_S) $(LDFLAGS) $(CFLAGS) $(INCS) | ||
| cc -o $@ $(C_S) $(LDFLAGS) $(CFLAGS) $(INCS) |
There was a problem hiding this comment.
This may not work on some Windows crossdev systems.
There was a problem hiding this comment.
my bad, I will add platform detection
| { | ||
| fprintf( stderr, "Found WCH Link\n" ); | ||
| } | ||
| #ifndef __FreeBSD__ |
There was a problem hiding this comment.
Please try to add support for these. Disabling functionality on specific platforms should only be done as a later "I give up"
There was a problem hiding this comment.
esp32 and b0003 need "hidapi_thread_pthread.h" which isn't provided by the port (package basically) right now. The header doesn't seem to be in the public hidapi interface, I'm not sure if other platforms package this with their hidapi package, I need to get a debian machine to check.
There was a problem hiding this comment.
I am not sure what you are referring to. hidapi.c/.h is provided alongside minichlink. They contain all of hidapi on all supported platforms.
|
Ah ha, I got it by updating hidapi in minichlink and pulling in the missing header. I'll create a different review for that, do you know if a hidapi update is safe? |
There should be no additional header. the provided hidapi.h/.c are fully merged for all platforms. |
2 participants
No description provided.