Open
Conversation
jayvdb
reviewed
Nov 23, 2018
jayvdb
reviewed
Nov 23, 2018
kiy4h
force-pushed
the
add-kotlin
branch
2 times, most recently
from
53da83a to
541db7d
Compare
Man-Jain
suggested changes
Nov 24, 2018
jayvdb
requested changes
Dec 5, 2018
Member
jayvdb
left a comment
jayvdb
left a comment
There was a problem hiding this comment.
many of these datatypes duplicate existing datatypes already defined.
siddhpant
suggested changes
Dec 5, 2018
Member
There was a problem hiding this comment.
Datatypes already exist. Please don't make duplicates.
Please rebase the branch to remove duplicates residing in your branch before your changes too. #84 has merged some datatypes (actually all you need) in their specific file.
siddhpant
reviewed
Dec 5, 2018
| @@ -0,0 +1,4 @@ | |||
| keyword: byte | |||
siddhpant
reviewed
Dec 5, 2018
| @@ -0,0 +1,4 @@ | |||
| keyword: int | |||
siddhpant
reviewed
Dec 5, 2018
| @@ -0,0 +1,4 @@ | |||
| keyword: long | |||
siddhpant
reviewed
Dec 5, 2018
| @@ -0,0 +1,4 @@ | |||
| keyword: short | |||
siddhpant
reviewed
Dec 5, 2018
| @@ -0,0 +1,5 @@ | |||
| type: string | |||
siddhpant
reviewed
Dec 5, 2018
| @@ -0,0 +1,4 @@ | |||
| keyword: double | |||
siddhpant
reviewed
Dec 5, 2018
| @@ -0,0 +1,4 @@ | |||
| keyword: float | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.