Skip to content

data/Language/Flow.yaml: Add Flow definition#91

Open
utkarsh2102 wants to merge 1 commit intocoala:masterfrom
utkarsh2102:Flow-yaml
Open

data/Language/Flow.yaml: Add Flow definition#91
utkarsh2102 wants to merge 1 commit intocoala:masterfrom
utkarsh2102:Flow-yaml

Conversation

@utkarsh2102
Copy link
Member

@utkarsh2102 utkarsh2102 commented Dec 5, 2018

This adds definition of Flow, a static type checker for JS.

Closes #51

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

@gitmate-bot rebase

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

Automated rebase with GitMate.io was successful! 🎉

jayvdb
jayvdb requested changes Dec 5, 2018
View reviewed changes
Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this language has no keywords?

no boolean or null literals?

@utkarsh2102
Copy link
Member Author

utkarsh2102 commented Dec 5, 2018 •
edited
Loading

this language has no keywords?

Flow is just a static type checker for JS. So thought of skipping the same.
Should I add it?

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

Flow is just a static type checker for JS.

coAST is about creating models to describe stuff. Not about omitting information.

@utkarsh2102
Copy link
Member Author

utkarsh2102 commented Dec 5, 2018

Flow is just a static type checker for JS.

coAST is about creating models to describe stuff. Not about omitting information.

Duly noted.
Will add them.
Do reply to the comments inline, too.

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

I have no intention of giving more feedback at this stage, as you have not yet attempted to model the language.

@utkarsh2102
Copy link
Member Author

utkarsh2102 commented Dec 5, 2018

Will do, thanks.

@jayvdb
Copy link
Member

jayvdb commented Dec 12, 2018

Comment on 6a22f54, file data/Language/VisualBasic.yaml, line 5.

line too long (82 > 80 characters) (line-length)

Origin: YAMLLintBear, Section: yaml.

pythongiant
pythongiant approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member

@pythongiant pythongiant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. nice stuff

@utkarsh2102
Copy link
Member Author

utkarsh2102 commented Dec 12, 2018

Comment on 6a22f54, file data/Language/VisualBasic.yaml, line 5.

line too long (82 > 80 characters) (line-length)

Origin: YAMLLintBear, Section: yaml.

This is not related to this PR. Moreover, this has been fixed already.

@li-boxuan
Copy link
Member

li-boxuan commented Dec 13, 2018

Needs rebase :)

@utkarsh2102
Copy link
Member Author

utkarsh2102 commented Dec 13, 2018

Needs rebase :)

Rebased. How does it look now?

li-boxuan
li-boxuan requested changes Dec 13, 2018
View reviewed changes
@utkarsh2102
Copy link
Member Author

utkarsh2102 commented Dec 13, 2018

@li-boxuan, done as asked :D
Could you take a look now?

@li-boxuan
Copy link
Member

li-boxuan commented Dec 14, 2018

Netlify is failing due to other reason now :)

@utkarsh2102
Copy link
Member Author

utkarsh2102 commented Dec 14, 2018

Netlify is failing due to other reason now :)

My bad. Resolved, @li-boxuan.
Let me know if there's any other issue in this PR.

@utkarsh2102
Copy link
Member Author

utkarsh2102 commented Dec 15, 2018

Rebased, too.

Naveenaidu
Naveenaidu approved these changes Dec 16, 2018
View reviewed changes
Copy link
Member

@Naveenaidu Naveenaidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

li-boxuan
li-boxuan reviewed Dec 16, 2018
View reviewed changes
@pythongiant
Copy link
Member

pythongiant commented Dec 16, 2018

I was about to point out what @li-boxuan did, but it looks good now.
The new modeling fixes this up.

ksdme
ksdme reviewed Dec 31, 2018
View reviewed changes
Copy link
Member

@ksdme ksdme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use a logo. https://commons.wikimedia.org/wiki/File:Flow_Static_Typechecker_for_JavaScript.svg

Naveenaidu
Naveenaidu approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@Naveenaidu Naveenaidu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

KVGarg
KVGarg approved these changes Feb 9, 2019
View reviewed changes
Copy link

@KVGarg KVGarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 👍

@utkarsh2102
data/Language/Flow.yaml: Add Flow definition
a39a062 
This adds definition of Flow, a static type checker for JS.

Closes coala#51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@li-boxuan li-boxuan li-boxuan requested changes

@jayvdb jayvdb jayvdb requested changes

+7 more reviewers

@ksdme ksdme ksdme approved these changes

@pythongiant pythongiant pythongiant approved these changes

@shashank-b shashank-b shashank-b approved these changes

@frextrite frextrite frextrite approved these changes

@Naveenaidu Naveenaidu Naveenaidu approved these changes

@rajgoesout rajgoesout rajgoesout approved these changes

@KVGarg KVGarg KVGarg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@utkarsh2102 utkarsh2102

Labels

difficulty/low process/pending review size/S

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@utkarsh2102 @jayvdb @li-boxuan @pythongiant @ksdme @shashank-b @frextrite @Naveenaidu @rajgoesout @KVGarg