Skip to content

plugin.xml: Rename 'coala-analyzer.gif' #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thotayashwanth123 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

plugin.xml: Rename 'coala-analyzer.gif' #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 com.coala.core/icons/coala-analyzer.gif → com.coala.core/icons/coala.gif
View file
Open in desktop
File renamed without changes
2 changes: 1 addition & 1 deletion com.coala.core/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
<menuContribution
locationURI="popup:org.eclipse.ui.popup.any?after=additions">
<menu
icon="icons/coala-analyzer.gif"
icon="icons/coala.gif"
Copy link
Member

@damngamerz damngamerz Feb 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In icons folder the file is named to be "coala-analyzer.gif" rename it to "coala.gif" might possibly fix the issue as well as ci failure!!

Copy link
Author

@thotayashwanth123 thotayashwanth123 Feb 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it, but again Travis is failling

Copy link
Member

@damngamerz damngamerz Feb 5, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thotayashwanth123 changed and committed the changes? still its failing..I cannot see your rename file commit!! can you plz do it so i can see trace back!!

Copy link
Member

@meetmangukiya meetmangukiya Feb 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to rename this file https://github.com/coala/coala-eclipse/blob/master/com.coala.core/icons/coala-analyzer.gif to coala.gif

id="com.coala.core.menus.popupMenu"
label="Run coala with"
mnemonic="o">
Expand Down