-
Notifications
You must be signed in to change notification settings - Fork 479
new MOLT Replicator metrics page #21600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
ryanluu12345
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content and layout look great! I think it's a really clean doc and intuitive. I left some comments just so Shashwat can clarify a few discrepancies I noted.
Regarding the layout, I don't think you need to show the "Staging" section for MySQL, Oracle, and PG sources. Staging is really only relevant for Cockroach sources. Can probably add conditional logic there. Other than that, sections look right to me.
| | Table exclusion filter | `--table-exclusion-filter` | POSIX regex matching table names to exclude across all selected schemas. | | ||
|
|
||
| {{site.data.alerts.callout_info}} | ||
| `--schema-filter` does not apply to MySQL sources because MySQL tables belong directly to the database specified in the connection string, not to a separate schema. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
DOC-15229