Skip to content
This repository was archived by the owner on Feb 23, 2024. It is now read-only.

add Colors, Type & Buttons Pages#3

Open
brandonalbright wants to merge 5 commits intomainfrom
Brandon
Open

add Colors, Type & Buttons Pages#3
brandonalbright wants to merge 5 commits intomainfrom
Brandon

Conversation

@brandonalbright
Copy link
Collaborator

Updated colors page to reflect Figma board

@brandonalbright brandonalbright changed the title Colors Page add Colors, Type & Buttons Pages May 26, 2021
@amandathedev amandathedev self-requested a review May 27, 2021 22:09
font-family: 'Karla', Helvetica;
font-size: 38px;
font-weight: bold;
line-height: 44px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[non-blocking] I'd recommend using rem instead of px for line-height and font-size. Here's some more info: https://css-tricks.com/is-it-better-to-use-ems-rems-than-px-for-font-size/

Copy link
Collaborator

@amandathedev amandathedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants