Skip to content

fix: prevent remaining duration from overwriting duration text (#3429) #3582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sanchita4collab wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: prevent remaining duration from overwriting duration text (#3429) #3582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions js&css/web-accessible/www.youtube.com/appearance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,34 +155,34 @@ ImprovedTube.formatSecond = function (rTime) {
};

ImprovedTube.playerRemainingDuration = function () {
const liveBadge = document.querySelector('button.ytp-live-badge.ytp-button.ytp-live-badge-is-livehead');
if (liveBadge) return;
const liveBadge = document.querySelector(
'button.ytp-live-badge.ytp-button.ytp-live-badge-is-livehead'
);
if (liveBadge) return;

const currentEl = document.querySelector('.ytp-time-current');
const durationEl = document.querySelector('.ytp-time-duration');
const currentEl = document.querySelector('.ytp-time-current');
const durationEl = document.querySelector('.ytp-time-duration');
if (!currentEl || !durationEl) return;

if (!currentEl || !durationEl) return;
const player = ImprovedTube.elements.player;
if (!player) return;

const player = ImprovedTube.elements.player;
if (!player) return;

const currentTime = player.getCurrentTime();
const duration = player.getDuration();

if (!isFinite(duration) || !isFinite(currentTime) || duration <= 0) return;
const currentTime = player.getCurrentTime();
const duration = player.getDuration();
if (!isFinite(duration) || !isFinite(currentTime) || duration <= 0) return;

const remainingSeconds = Math.max(0, duration - currentTime);
const rTime = ImprovedTube.formatSecond(Math.floor(remainingSeconds));

if (!rTime || rTime.includes('NaN')) return;
const remainingSeconds = Math.max(0, duration - currentTime);
const rTime = ImprovedTube.formatSecond(Math.floor(remainingSeconds));
if (!rTime || rTime.includes('NaN')) return;

if (!durationEl.dataset.itOriginal) {
durationEl.dataset.itOriginal = durationEl.textContent;
}
// Save original duration ONCE (clean version)
if (!durationEl.dataset.itOriginal) {
durationEl.dataset.itOriginal = durationEl.textContent.trim();
}

// Overwrite text
durationEl.textContent =
durationEl.dataset.itOriginal + ' (-' + rTime + ')';
// Always reset to original and append remaining time
durationEl.textContent =
`${durationEl.dataset.itOriginal} (-${rTime})`;
};


Expand Down