add file download to sdk #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The failing tests were unrelated to these changes, I can only presume something changed in how click handled mock input during testing. The tests are now fixed, and I verified manually as well that the command is still functioning as expected. |
tora-kozic
reviewed
May 27, 2025
| mock_file_not_found.check() | ||
|
|
||
|
|
||
| def test_stream_file_by_sha256_streams_file(mock_file_download): |
Contributor
There was a problem hiding this comment.
maybe a sad path test for this one too?
tora-kozic
approved these changes
May 27, 2025
jdullum
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds files clients and command groups and associated methods.