Integ 2939/add orgs #154
Merged
Integ 2939/add orgs #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdullum
approved these changes
Jun 3, 2025
|
|
||
|
|
||
| class CreatorUser(ResponseModel): | ||
| user_id: Optional[str] = Field( |
Contributor
There was a problem hiding this comment.
Why are all of the fields marked as Optional? I noticed that is the pattern on existing response models too.
Contributor
Author
There was a problem hiding this comment.
If we don't mark them as optional, if they're ever missing the SDK will throw an exception instead of giving you the response, so we do it to try and make the user experience a bit smoother.
jdullum
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds orgs and legal hold clients