feat: Enhance Drawer component with scroll locking functionality #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `lockScroll` prop to control body scroll behavior when the drawer is open. - Implemented `lockScroll` and `unlockScroll` methods to manage overflow style. - Ensured scroll is unlocked when the component is destroyed. - Updated usage in SongFloatingToolbox to reflect the new prop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏷️ PR Title:
Enhance Drawer component with scroll locking functionality
📋 Summary
This PR adds scroll locking functionality to the Drawer component, preventing background content from scrolling when the drawer is open. This improves user experience by keeping focus on the drawer content.
🔗 Related Tasks
#06e1cef - Enhance Drawer component with scroll locking functionality
📝 Additional Details
The implementation ensures that the scroll lock is applied and removed appropriately as the drawer opens and closes, maintaining accessibility and usability standards.
📜 Commit List
06e1cef feat: Enhance Drawer component with scroll locking functionality