Cu 86eunvbgj implement the input group component navid shad #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mprove disabled state handling - Enhanced Input, Button, and Select components to manage disabled states based on InputGroup context, allowing for more flexible and consistent behavior. - Updated the logic for determining the disabled state to prioritize child component settings over InputGroup settings. - Adjusted related tests to reflect changes in how disabled states are applied and verified across components.
- Introduced a new `selected` slot in the Select component to allow customization of how selected options are displayed in the trigger button. - Updated the Select component to handle both single and multiple selection modes, providing scoped variables for selected options. - Enhanced Storybook examples to demonstrate the new functionality, including custom display for selected items and handling of multiple selections. - Refactored related rendering logic to support the new slot and improve overall component behavior.
…s consistency - Added guidelines to ensure all story args are passed to components via props using `v-bind="args"`. - Emphasized the importance of not hardcoding props in templates and ensuring all component props are controllable through Storybook controls. - Included examples for correct and incorrect usage of props in templates to enhance clarity and adherence to best practices.
Contributor
Author
|
Task linked: CU-86eunvbgj Implement the Input Group component |
|
🎉 This PR is included in version 1.17.0-dev.38 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.28.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏷️ PR Title: Enhance Select Component with Custom Selected Display Slot and Improve Disabled State Handling
📋 Summary
This PR introduces a custom selected display slot to the Select component, allowing greater flexibility in how selected options are rendered. Additionally, it refactors the Input, Button, and Select components to improve the handling of their disabled states. The Storybook development guidelines have also been updated to enforce consistency between Args and Props across components.
🔗 Related Tasks
#86eunvbgj - Update Input, Button, and Select components to improve disabled state handling
📝 Additional Details
📜 Commit List
5fbb480 docs: Update Storybook Development Guidelines to enforce Args-to-Props consistency
79d98b7 feat: Add custom selected display slot to Select component
6e6acd2 refactor: #86eunvbgj Update Input, Button, and Select components to improve disabled state handling