Add method for sending mail without template and update README.md#2
Open
rainabba wants to merge 6 commits intocodedoctor:masterfrom
Open
Add method for sending mail without template and update README.md#2rainabba wants to merge 6 commits intocodedoctor:masterfrom
rainabba wants to merge 6 commits intocodedoctor:masterfrom
Conversation
Update README.md for sendNoTemplate
Author
|
Btw, thank you for this library. I'd done a very basic one (not as a proper Hapi plugin) and was about to do almost exactly what you'd already done so I'm happy to contribute. |
Author
|
Should I provide any more PRs? I have no interest in CoffeeScript and too couldn't justify the time even if I did so I won't be able to help with those tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated README.md for the new method and fixed a minor refrence (hapi 8 server.pack is gone).
I did look at adding a test, but I don't use coffeescript and can barely read it, but the implementation is very simple so for someone that does know coffeescript, adding a test should take minutes.