This repository was archived by the owner on Sep 6, 2020. It is now read-only.
Open
Conversation
これで解決できる問題は詳細画面で「0時0分だったら」という分岐が「nullだったら」という分岐になって意図がちょっとだけわかりやすくなります。 想定データ構造 ・開始時刻のみ －＞startに開始時刻設定 ／ endはnull ・日付のみ －＞startに日付+0時0分 ／ endはnull これを取り込むにはjsonデータの生成処理も合わせて修正する必要があります。 リファクタブランチなので取り込まなくてもＯＫです。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
endの時刻がnullでも動くようにしました。
これで解決できる問題は詳細画面で「0時0分だったら」という分岐が「nullだったら」という分岐になって意図がちょっとだけわかりやすくなります。
想定データ構造
・開始時刻のみ
－＞startに開始時刻設定 ／ endはnull
・日付のみ
－＞startに日付+0時0分 ／ endはnull
これを取り込むにはjsonデータの生成処理も合わせて修正する必要があります。
リファクタブランチなので取り込まなくてもＯＫです。