Skip to content

Hms fix geofencing #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
minUswachoke wants to merge 2 commits into from
Closed

Hms fix geofencing #73

minUswachoke wants to merge 2 commits into from

Conversation

@minUswachoke
Copy link

@minUswachoke minUswachoke commented Jan 21, 2021

  • ADD NativeModule to check whether user phone is GMS or HMS phone
  • ADD Huawei Location Libs to project
  • initialize Huawei Location in BackgroundTracking
  • update Location every 5min

min added 2 commits January 12, 2021 08:04
This version only remove the dialog "GMS unavailable" from onboarding…
186ff97 
… stage. Not in the mainpage, since that have to fix the location issue and might effect alot of code. What I did

1. Add Native module to check for HMS and GMS phone
 2. The dialog come from the method backgroundTracking.start()
3. I cover the method checking if the phone is IOS or having GMS in the android phone to use the method
4. Requesting background location somehow didnt work in request method, this also doesnt work in normal build. But 'backgroundTracking.start() is requesting it.
5. HMS phone will not be requesting for location
retriving location every 5min
c9e1a38
@n3tr
Copy link
Collaborator

n3tr commented Jan 21, 2021

Please branch out from master instead of align-master, we are not using that branch anymore.

I have some suggestions for the implementation

  • We don't need to implement a Native Module for detecting GMS, since react-native-device-info provides that function already (already on master).
  • If possible, We should not modify BackgroundTracking class
    • Instead we implement a class for HMS one separately, maybe called HMSBackgoundTracking and expose the same interface as BackgroundTracking - eg. start|stop|getLocations. (I will soon add this interface)
    • Then we can have LocationTrackingManager and it will initiate a background tracking instance based on the device.
    • And the main app interact only with the LocationTrackingManager
  • Would be good we HMSBackgoundTracking also has a function to send a location to the server.

@n3tr
Copy link
Collaborator

n3tr commented Feb 12, 2021

closed in favor of #74

@n3tr n3tr closed this Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@minUswachoke @n3tr