refactor: Rework Entity class

[neznaika0]

Description
I keep track of entity changes. At the moment, I don't see any conflicts when using 'attributes' as the column name.
There was also a bug with the restore of $_cast.

Question: Do I need to get rid of the DataCaster object? For example, I completely disabled casting in the Entity and transform it into a Model. But the object is always being created.

I could, under the condition $_cast = false, not create it or destroy it when calling $this->cast(false). We can simplify by calling getDataCaster() "on the fly", although it's no better to create an object every time. Suggestions?

It is also planned to update the DateCast to use the interface, since it does not always set DateTime, but also DateTimeImmutable.

PR should be taken after #9877 But we can discuss it now.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[neznaika0]

An actual note? We can already have the 'attributes' field

https://github.com/neznaika0/codeigniter-dev/blob/9ac23b4c207c6bea12b4ebb1a085d3ab57942baf/user_guide_src/source/models/entities.rst?plain=1#L43

[michalsn]

Some initial comments added.

If you fix a bug, it should be mentioned in the changelog as well.

[neznaika0]

If you fix a bug, it should be mentioned in the changelog as well.

I've lost the changes. I'll fix it

[neznaika0]

• Now we rely on a flag and an empty array. It would be wrong if any of these values are true and the DataCaster is created.
• The guide has been updated. The question remains refactor: Rework Entity class #9878 (review)

[neznaika0]

Additionally:

• I would return the array check and fix fill() -null is never needed there.

    public function __construct(array $data = [])
    {
       // ...

        $this->syncOriginal()->fill($data);
    }

    public function fill(array $data)
    {
        // ...
    }

[michalsn]

• The question remains refactor: Rework Entity class #9878 (review)

I think we could already with _setAttributes(). Since we dropped setAttributes(), I see no problem with removing this note.

I would return the array check and fix fill() -null is never needed there.

Users are allowed to create the Entity and fill it later. This change could break people's apps.

[neznaika0]

Users are allowed to create the Entity and fill it later. This change could break people's apps.

How? Does the default constructor have an empty array, and fill() without an array doesn't matter?

[michalsn]

How? Does the default constructor have an empty array, and fill() without an array doesn't matter?

This is a BC break, which has no real benefit.

[neznaika0]

Good. Let's leave it. But we're breaking in 4.7. In my opinion, using null is the wrong developer code. php8.5 has already been released, and we still support the old standards. Of course, this is a concern for the developers...

[michalsn]

Good. Let's leave it. But we're breaking in 4.7. In my opinion, using null is the wrong developer code. php8.5 has already been released, and we still support the old standards. Of course, this is a concern for the developers...

We do allow BC breaks, but only when they provide clear value or affect minimally exposed internals. This change does neither and would introduce unnecessary risk for users.

That said, I'm not stubborn... if other maintainers think that this is the right direction, then I won't be opposed.

[michalsn]

Other than this, looks good to me. Thanks.

[michalsn]

Final round from me, cleanup only.

[michalsn]

Suggested change

	/**
	* This method allows you to refuse to contain an unnecessary DataCaster if you do not use casting.
	*/
	/**
	* Returns a DataCaster instance when casts are defined.
	* If no casts are configured, no DataCaster is created and null is returned.
	*/

[michalsn]

This is not needed as $_cast does not decide about DataCaster initialization.