Skip to content

fix: make router cache attributes time independent #9881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michalsn merged 3 commits into from
Jan 10, 2026
Merged

fix: make router cache attributes time independent #9881

michalsn merged 3 commits into from
Jan 10, 2026
+17 −4

Conversation

@michalsn
Copy link
Member

@michalsn michalsn commented Jan 10, 2026

Description
This PR replaces time() calls with the mockable Time class to decouple router cache from the current time.

See: #9874 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added testing Pull requests that changes tests only 4.7 labels Jan 10, 2026
@michalsn michalsn merged commit cb9bcc8 into codeigniter4:4.7 Jan 10, 2026
49 checks passed
@michalsn
Copy link
Member Author

michalsn commented Jan 10, 2026

Thank you @paulbalandan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

4.7 testing Pull requests that changes tests only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michalsn @paulbalandan