codenameone · shai-almog · Jan 28, 2026 · Jan 28, 2026
diff --git a/.github/scripts/generate-quality-report.py b/.github/scripts/generate-quality-report.py
@@ -927,7 +927,11 @@ def _is_exempt(f: Finding) -> bool:
             "DoNotCallGarbageCollectionExplicitly",
             "SuspiciousEqualsMethodName",
             "UseUtilityClass",
-            "EmptyCatchBlock"
+            "EmptyCatchBlock",
+            "SimplifyBooleanReturns",
+            "UnusedLocalVariable",
+            "UnnecessaryConstructor",
+            "UnnecessaryImport"
         }
         violations = [f for f in pmd.findings if f.rule in forbidden_pmd_rules]
         if violations:

diff --git a/CodenameOne/src/com/codename1/ads/InnerActive.java b/CodenameOne/src/com/codename1/ads/InnerActive.java
@@ -48,12 +48,6 @@ public class InnerActive extends AdsService { // PMD Fix: UnusedPrivateField rem
     private String hid;
     private boolean banner = true;
 
-    /**
-     * Empty constructor of the inner active ads service.
-     */
-    public InnerActive() {
-    }
-
     private static void addParam(ConnectionRequest req, String key, String val) {
         if (val != null && val.length() > 0) {
             req.addArgument(key, val);
@@ -157,37 +151,18 @@ public void initService(Ads ads) {
         setDuplicateSupported(true);
     }
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public boolean equals(Object o) {
-        if (this == o) {
-            return true;
-        }
-        if (o == null || getClass() != o.getClass()) {
+        if (!(o instanceof InnerActive)) {
             return false;
         }
-        if (!super.equals(o)) {
-            return false;
-        }
-
         InnerActive that = (InnerActive) o;
-
-        if (po != that.po) {
-            return false;
-        }
-        if (banner != that.banner) {
-            return false;
-        }
-        if (os != null ? !os.equals(that.os) : that.os != null) {
-            return false;
-        }
-        if (hid != null ? !hid.equals(that.hid) : that.hid != null) {
-            return false;
-        }
-
-        return true;
+        return super.equals(o) &&
+                po == that.po &&
+                banner == that.banner &&
+                REQUEST_URL.equals(that.REQUEST_URL) &&
+                (os == null ? that.os == null : os.equals(that.os)) &&
+                (hid == null ? that.hid == null : hid.equals(that.hid));
     }
 
     /**

diff --git a/CodenameOne/src/com/codename1/components/RSSReader.java b/CodenameOne/src/com/codename1/components/RSSReader.java
@@ -485,21 +485,15 @@ public void actionPerformed(ActionEvent ev) {
             sourceForm.showBack();
         }
 
-        /**
-         * {@inheritDoc}
-         */
         @Override
         public boolean equals(Object o) {
-            if (this == o) {
-                return true;
-            }
-            if (o == null || getClass() != o.getClass()) {
-                return false;
-            }
-            if (!super.equals(o)) {
+            if (!(o instanceof BackCommand)) {
                 return false;
             }
-            return true;
+            BackCommand that = (BackCommand) o;
+            return super.equals(o) &&
+                    (sourceForm == null ? that.sourceForm == null :
+                            sourceForm.equals(that.sourceForm));
         }
 
         @Override

diff --git a/CodenameOne/src/com/codename1/contacts/Address.java b/CodenameOne/src/com/codename1/contacts/Address.java
@@ -35,12 +35,6 @@ public class Address {
     private String postalCode;
     private String country;
 
-    /**
-     * Empty Constructor
-     */
-    public Address() {
-    }
-
     /**
      * Gets Address Country
      *

diff --git a/CodenameOne/src/com/codename1/contacts/Contact.java b/CodenameOne/src/com/codename1/contacts/Contact.java
@@ -67,12 +67,6 @@ public class Contact {
 
     private String[] linkedIds;
 
-    /**
-     * Empty Constructor
-     */
-    public Contact() {
-    }
-
     /**
      * Gets the Contact Addresses, the Hashtable contains key/value pairs where
      * the key is a String which represents the type of the Address, types can

diff --git a/CodenameOne/src/com/codename1/facebook/FacebookRESTService.java b/CodenameOne/src/com/codename1/facebook/FacebookRESTService.java
@@ -297,34 +297,19 @@ public void longToken(long tok) {
     public void booleanToken(boolean tok) {
     }
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public boolean equals(Object o) {
-        if (this == o) {
-            return true;
-        }
-        if (o == null || getClass() != o.getClass()) {
+        if (!(o instanceof FacebookRESTService)) {
             return false;
         }
-        if (!super.equals(o)) {
-            return false;
-        }
-
         FacebookRESTService that = (FacebookRESTService) o;
-
-        if (responseOffset != that.responseOffset) {
-            return false;
-        }
-        if (connectionType != null ? !connectionType.equals(that.connectionType) : that.connectionType != null) {
-            return false;
-        }
-        if (root != null ? !root.equals(that.root) : that.root != null) {
-            return false;
-        }
-
-        return true;
+        return super.equals(o) && responseOffset == that.responseOffset &&
+                entry.equals(that.entry) &&
+                stack.equals(that.stack) &&
+                (currentData == null ? that.currentData == null : currentData.equals(that.currentData)) &&
+                (connectionType == null ? that.connectionType == null : connectionType.equals(that.connectionType)) &&
+                (responseDestination == null ? that.responseDestination == null : responseDestination.equals(that.responseDestination)) &&
+                (root == null ? that.root == null : root.equals(that.root));
     }
 
     /**

diff --git a/CodenameOne/src/com/codename1/io/JSONParser.java b/CodenameOne/src/com/codename1/io/JSONParser.java
@@ -791,7 +791,6 @@ public void setStrict(boolean strict) {
     @Override
     public void startArray(String arrayName) {
         java.util.List<Object> currentVector;
-        Map newOne;
         if (modern) {
             currentVector = new ArrayList<Object>();
         } else {

diff --git a/CodenameOne/src/com/codename1/io/MultipartRequest.java b/CodenameOne/src/com/codename1/io/MultipartRequest.java
@@ -513,31 +513,22 @@ public void setBase64Binaries(boolean base64Binaries) {
         this.base64Binaries = base64Binaries;
     }
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public boolean equals(Object o) {
-        if (this == o) {
-            return true;
-        }
-        if (o == null || getClass() != o.getClass()) {
+        if (!(o instanceof MultipartRequest)) {
             return false;
         }
-        if (!super.equals(o)) {
-            return false;
-        }
-
         MultipartRequest that = (MultipartRequest) o;
-
-        if (boundary != null ? !boundary.equals(that.boundary) : that.boundary != null) {
-            return false;
-        }
-        if (args != null ? !args.equals(that.args) : that.args != null) {
-            return false;
-        }
-
-        return true;
+        return super.equals(o) &&
+                contentLength == that.contentLength &&
+                manualRedirect == that.manualRedirect &&
+                base64Binaries == that.base64Binaries &&
+                (boundary == null ? that.boundary == null : boundary.equals(that.boundary)) &&
+                (args == null ? that.args == null : args.equals(that.args)) &&
+                (filenames == null ? that.filenames == null : filenames.equals(that.filenames)) &&
+                (filesizes == null ? that.filesizes == null : filesizes.equals(that.filesizes)) &&
+                (mimeTypes == null ? that.mimeTypes == null : mimeTypes.equals(that.mimeTypes)) &&
+                (ignoreEncoding == null ? that.ignoreEncoding == null : ignoreEncoding.equals(that.ignoreEncoding));
     }
 
     /**

diff --git a/CodenameOne/src/com/codename1/io/Oauth2.java b/CodenameOne/src/com/codename1/io/Oauth2.java
@@ -522,7 +522,6 @@ class TokenRequest extends ConnectionRequest {
                     protected void readResponse(InputStream input) throws IOException {
                         byte[] tok = Util.readInputStream(input);
                         String t = StringUtil.newString(tok);
-                        boolean expiresRelative = true;
                         if (t.startsWith("{")) {
                             JSONParser p = new JSONParser();
                             Map map = p.parseJSON(new StringReader(t));

diff --git a/CodenameOne/src/com/codename1/io/gzip/Deflate.java b/CodenameOne/src/com/codename1/io/gzip/Deflate.java
@@ -750,7 +750,6 @@ void copyBlock(int buf,         // the input data
                    int len,         // its length
                    boolean header   // true if block header must be written
     ) {
-        int index = 0;
         biWindup();      // align on byte boundary
         lastEobLen = 8; // enough lookahead for inflate
 

diff --git a/CodenameOne/src/com/codename1/io/gzip/GZConnectionRequest.java b/CodenameOne/src/com/codename1/io/gzip/GZConnectionRequest.java
@@ -45,28 +45,13 @@
 public class GZConnectionRequest extends ConnectionRequest {
     private boolean isGzipped;
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public boolean equals(Object o) {
-        if (this == o) {
-            return true;
-        }
-        if (o == null || getClass() != o.getClass()) {
-            return false;
-        }
-        if (!super.equals(o)) {
+        if (!(o instanceof GZConnectionRequest)) {
             return false;
         }
-
         GZConnectionRequest that = (GZConnectionRequest) o;
-
-        if (isGzipped != that.isGzipped) {
-            return false;
-        }
-
-        return true;
+        return super.equals(o) && isGzipped == that.isGzipped;
     }
 
     /**

diff --git a/CodenameOne/src/com/codename1/io/gzip/Inflate.java b/CodenameOne/src/com/codename1/io/gzip/Inflate.java
@@ -165,8 +165,6 @@ int inflateInit(int w) {
 
     @SuppressWarnings("PMD.UnnecessaryLocalBeforeReturn")
     int inflate(int f) {
-        int hold = 0;
-
         int r;
         int b;
 
@@ -622,7 +620,6 @@ int inflateSetDictionary(byte[] dictionary, int dictLength) {
     int inflateSync() {
         int n;       // number of bytes to look at
         int p;       // pointer to bytes
-        int m;       // number of marker bytes found in a row
         long r;   // temporaries to save total_in and total_out
         long w;
 

diff --git a/CodenameOne/src/com/codename1/io/rest/RequestBuilder.java b/CodenameOne/src/com/codename1/io/rest/RequestBuilder.java
@@ -1073,28 +1073,18 @@ public Connection(boolean parseJSON) {
             this.parseJSON = parseJSON;
         }
 
-        /**
-         * {@inheritDoc}
-         */
         @Override
         public boolean equals(Object o) {
-            if (this == o) {
-                return true;
-            }
-            if (o == null || getClass() != o.getClass()) {
-                return false;
-            }
-            if (!super.equals(o)) {
+            if (!(o instanceof Connection)) {
                 return false;
             }
-
             Connection that = (Connection) o;
-
-            if (parseJSON != that.parseJSON) {
-                return false;
-            }
-
-            return true;
+            return super.equals(o) &&
+                    errorCode == that.errorCode &&
+                    parseJSON == that.parseJSON &&
+                    (json == null ? that.json == null : json.equals(that.json)) &&
+                    (errorHandler == null ? that.errorHandler == null : errorHandler.equals(that.errorHandler)) &&
+                    (errorObject == null ? that.errorObject == null : errorObject.equals(that.errorObject));
         }
 
         /**

diff --git a/CodenameOne/src/com/codename1/io/services/CachedDataService.java b/CodenameOne/src/com/codename1/io/services/CachedDataService.java
@@ -80,21 +80,15 @@ public static void updateData(CachedData d, ActionListener callback) {
         NetworkManager.getInstance().addToQueue(c);
     }
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public boolean equals(Object o) {
-        if (this == o) {
-            return true;
-        }
-        if (o == null || getClass() != o.getClass()) {
-            return false;
-        }
-        if (!super.equals(o)) {
+        if (!(o instanceof CachedDataService)) {
             return false;
         }
-        return true;
+        CachedDataService that = (CachedDataService) o;
+        return super.equals(o) &&
+                responseProcessed == that.responseProcessed &&
+                data.equals(that.data);
     }
 
     @Override

diff --git a/CodenameOne/src/com/codename1/io/services/RSSService.java b/CodenameOne/src/com/codename1/io/services/RSSService.java
@@ -90,37 +90,19 @@ public RSSService(String url, int limit, int startOffset) {
         setDuplicateSupported(true);
     }
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public boolean equals(Object o) {
-        if (this == o) {
-            return true;
-        }
-        if (o == null || getClass() != o.getClass()) {
+        if (!(o instanceof RSSService)) {
             return false;
         }
-        if (!super.equals(o)) {
-            return false;
-        }
-
         RSSService that = (RSSService) o;
-
-        if (limit != that.limit) {
-            return false;
-        }
-        if (startOffset != that.startOffset) {
-            return false;
-        }
-        if (createPlainTextDetails != that.createPlainTextDetails) {
-            return false;
-        }
-        if (iconPlaceholder != null ? !iconPlaceholder.equals(that.iconPlaceholder) : that.iconPlaceholder != null) {
-            return false;
-        }
-
-        return true;
+        return super.equals(o) &&
+                limit == that.limit &&
+                startOffset == that.startOffset &&
+                hasMore == that.hasMore &&
+                createPlainTextDetails == that.createPlainTextDetails &&
+                (results == null ? that.results == null : results.equals(that.results)) &&
+                (iconPlaceholder == null ? that.iconPlaceholder == null : iconPlaceholder.equals(that.iconPlaceholder));
     }
 
     /**