🤖 tests: wait for post-highlighting scroll RAF in CodeBlocks story #1265
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
changed the title
ammar-agent
force-pushed
the
fix-codeblocks-story-flaky
branch
2 times, most recently
from
aa18dd2 to
be8b6f9
Compare
The CodeBlocks story was flaky because after Shiki highlighting completes, code block heights change which triggers the ResizeObserver in useAutoScroll to schedule a coalesced RAF scroll. Chromatic could capture the snapshot before this RAF completed. Add a double-RAF wait after verifying highlighting is done, matching the pattern used in useAutoScroll.performAutoScroll() and the expandAllBashTools helper. --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high`_
ammar-agent
force-pushed
the
fix-codeblocks-story-flaky
branch
from
be8b6f9 to
867869e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CodeBlocks story was flaky because after Shiki highlighting completes, code block heights change which triggers the ResizeObserver in
useAutoScrollto schedule a coalesced RAF scroll. Chromatic could capture the snapshot before this RAF completed.Add a double-RAF wait after verifying highlighting is done, matching the pattern used in
useAutoScroll.performAutoScroll()and theexpandAllBashToolshelper.Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high