Skip to content

Add shell syntax checker to CI and Fish completion documentation #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hasit wants to merge 2 commits into from
Closed

Add shell syntax checker to CI and Fish completion documentation #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e3b6cd
Add instructions for enabling fish shell completions for git gtr
hasit Dec 10, 2025
2ec73e9
feat: add shell-check pre-merge checks for script validation
hasit Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .coderabbit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ reviews:
auto_review:
enabled: true
drafts: false
pre_merge_checks:
custom_checks:
- mode: error
name: shell-check
instructions: |
- Always check if the shell scripts are valid and sytactically correct.
- Make sure there are examples for all the supported shells, such as bash, zsh, fish, etc.
Comment on lines +19 to +25
Copy link

@coderabbitai coderabbitai bot Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix typo in shell-check instructions.

Line 24 contains "sytactically" which should be "syntactically".

  pre_merge_checks:
    custom_checks:
      - mode: error
        name: shell-check
        instructions: |
-         - Always check if the shell scripts are valid and sytactically correct.
+         - Always check if the shell scripts are valid and syntactically correct.
          - Make sure there are examples for all the supported shells, such as bash, zsh, fish, etc.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
pre_merge_checks:
custom_checks:
- mode: error
name: shell-check
instructions: |
- Always check if the shell scripts are valid and sytactically correct.
- Make sure there are examples for all the supported shells, such as bash, zsh, fish, etc.
pre_merge_checks:
custom_checks:
- mode: error
name: shell-check
instructions: |
- Always check if the shell scripts are valid and syntactically correct.
- Make sure there are examples for all the supported shells, such as bash, zsh, fish, etc.
🤖 Prompt for AI Agents 
In .coderabbit.yaml around lines 19 to 25, the custom_check instruction text has
a typo: replace "sytactically" with "syntactically" in the shell-check
instructions so the line reads "Always check if the shell scripts are valid and
syntactically correct." and keep the rest of the block unchanged.


chat:
auto_reply: true
5 changes: 5 additions & 0 deletions templates/setup-example.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,8 @@ echo "✅ git gtr configured!"
echo ""
echo "View config with: git config --local --list | grep gtr"
echo "Create a worktree with: git gtr new my-feature"

# Fish shell completions for git gtr
echo "To enable fish shell completions for git gtr, run:"
echo " ln -s /path/to/git-worktree-runner/completions/gtr.fish ~/.config/fish/completions/"
echo "Then reload fish with: exec fish"