-
Notifications
You must be signed in to change notification settings - Fork 27
govulncheck: run from a container #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
see changes for the govulncheck-action in codeready-toolchain/toolchain-cicd#159 also, update ignored vulnerabilities (remove obsolete and unneeded π€·ββοΈ) Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
WalkthroughThis pull request updates the govulncheck GitHub Actions workflow configuration and extends the silence-until dates for managed vulnerabilities. The workflow configuration enables debug mode and simplifies version/cache settings, while the vulnerability ignore list reorders entries and shifts expiration dates forward by approximately one month. Changes
Estimated code review effortπ― 1 (Trivial) | β±οΈ ~5 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touchesβ Failed checks (1 warning)
β Passed checks (2 passed)
β¨ Finishing touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
af035f8 to
740ea5a
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π Files selected for processing (2)
.github/workflows/govulncheck.yml(1 hunks).govulncheck.yaml(1 hunks)
β° Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Verify Dependencies
π Additional comments (1)
.govulncheck.yaml (1)
2-26: Address trailing whitespace and clarify vulnerability silencing strategy.Line 26 contains trailing whitespace that should be removed. More importantly, the silencing dates warrant clarification:
- GO-2025-4010 (net/url) is silenced until 2026-01-03
- GO-2025-4007, GO-2025-4009, GO-2025-4011 are silenced until 2026-01-10 (one week later)
The inconsistent dates suggest these may have been set at different times or based on different upgrade timelines. Additionally, the PR description mentions "removes entries described as obsolete and unneeded," but the provided code shows reordering with date extensions rather than removals. Please clarify:
- Were any vulnerability entries actually removed (not shown in this diff)?
- Are these silence-until dates based on planned Go version upgrades, or are they preventative?
- Should GO-2025-4010 be aligned with the others at 2026-01-10 for consistency?
Apply this diff to remove trailing whitespace:
- id: GO-2025-4011 info: https://pkg.go.dev/vuln/GO-2025-4011 silence-until: 2026-01-10 -
| config: .govulncheck.yaml | ||
| debug: true # optional (default = false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π§© Analysis chain
π Web query:
codeready-toolchain/toolchain-cicd govulncheck-action action.yml parameters
π‘ Result:
Here are the inputs (parameters) defined for the govulncheck GitHub Action (action.yml) and their defaults/meanings:
- go-version-input: Version of Go to use for govulncheck (optional). [1][2]
- check-latest: Whether to always check for the latest Go version satisfying the spec (optional, default: false). [1][2]
- cache: Whether to enable Go caching (optional, default: true). [1][2]
- cache-dependency-path: Path to dependency file used for cache (optional, default: '') (useful for monorepos). [2]
- go-package (aka go-package / go-package): Package pattern to scan (optional, default: './...'). [1][2]
- work-dir (work-dir / work-dir): Directory in which to run govulncheck (optional, default: '.'). [1][2]
- repo-checkout: Whether to checkout the repository before running (optional, default: true). [1][2]
- go-version-file: Path to go.mod or go.work file used to determine Go version (optional, default: ''). [1][2]
- output-format: govulncheck output format ('text', 'json', 'sarif') (optional, default: 'text'). [2]
- output-file: File to which govulncheck output is redirected (optional, default: ''). [2]
- (other variants / forks) go-version / vulncheck-version / package / working-directory / github-token / fail-on-vuln / skip-upload β used by some community forks (defaults vary by fork). [3][5]
Sources:
[1] govulncheck-action action.yml (Go mirror).
[2] golang/govulncheck-action README (GitHub mirror).
[3] Templum/govulncheck-action README (community fork showing alternative input names).
π Script executed:
# Fetch the action.yml file from the govulncheck-action repository
curl -s https://raw.githubusercontent.com/codeready-toolchain/toolchain-cicd/master/govulncheck-action/action.ymlRepository: codeready-toolchain/api
Length of output: 81
π Script executed:
# Also check if README exists with parameter documentation
curl -s https://raw.githubusercontent.com/codeready-toolchain/toolchain-cicd/master/govulncheck-action/README.md | head -100Repository: codeready-toolchain/api
Length of output: 1722
Remove the debug parameter and trailing whitespace on line 19.
The debug: true parameter is not documented in the codeready-toolchain/toolchain-cicd govulncheck-action and should be removed, as it appears to be an unsupported input. Line 19 also has a trailing space after .govulncheck.yaml that should be cleaned up. The config parameter is valid and correctly supported by this custom action.
π€ Prompt for AI Agents
.github/workflows/govulncheck.yml around lines 19-20: remove the unsupported
"debug: true" input and trim the trailing whitespace after ".govulncheck.yaml"
on the config line; leave the valid "config: .govulncheck.yaml" entry but ensure
there is no trailing space and delete the entire "debug: true" line so only
supported inputs remain.



see changes for the govulncheck-action in codeready-toolchain/toolchain-cicd#159
also, update ignored vulnerabilities (remove obsolete and unneeded π€·ββοΈ)
Signed-off-by: Xavier Coulon xcoulon@redhat.com
Summary by CodeRabbit
Release Notes
βοΈ Tip: You can customize this high-level summary in your review settings.