Skip to content

chore: prework for npm publish #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mkramb wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

chore: prework for npm publish #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33c8659
chore: prework for npm publish
mkramb Oct 4, 2018
5ecce49
fix
mkramb Oct 4, 2018
895ae6f
Merge branch 'master' into chore/prework-for-npm-publish
ryanjwilke Oct 4, 2018
61345a9
another fix
mkramb Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
*
!assets/stylesheets/**/*
!assets/images/**/*
!assets/icons/**/*
5 changes: 5 additions & 0 deletions ci/npm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
#!/bin/bash
set -e # halt script on error

echo -e "\n\n************** NPM publish for @codeship/shipyard **************"
npm publish --access public
Copy link
Author

@mkramb mkramb Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I misunderstood the build system,
this should be called as a step on master branch - same as other scripts.

Copy link
Author

@mkramb mkramb Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codebryo @ryanjwilke
Do we need to authenticate against NPM or is that configured automatically for the build? How are you doing that for other NPM codeship packages - which have scoped package @codeship

Copy link
Author

@mkramb mkramb Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume that would be injected as environment variables from the pipeline configuration.

4 changes: 4 additions & 0 deletions codeship-steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,7 @@
service: shipyard
name: GitHub Pages
command: ./ci/github
-
Copy link
Author

@mkramb mkramb Oct 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be executed only on master branch.

service: shipyard
name: NPM publish
command: ./ci/npm