my-first-Pull request #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- scss로 꾸밈 - 레이아웃 속성으로 `flex`를 사용함
leaf-upper
reviewed
Feb 15, 2020
| case 'add ': | ||
| return(result: left + right); | ||
| default: | ||
| return state; |
There was a problem hiding this comment.
함수의 결과로 연산의 결과 값을 반환하는것 같은데 만약 연산의 오류로 default값에 switch문이 들어가서
state를 return하게 되면 어떻게 되나요? 원래 state를 반환해야하는것인지 아니면 그렇게쓰신 의미가 있는지 궁금합니다!
| const TodoListItem = ({ todo }) => { | ||
| const { text, checked } = todo; | ||
| return ( | ||
| <div className="TodoListItem"> |
There was a problem hiding this comment.
div 에서 속성값으로 class가 아닌 className을 주는게 리액트의 방식인가요? 오늘 스터디에서 말하셨던 내용이 맞는지 궁금합니다
내용 정리/3. 컴포넌트.md
Outdated
There was a problem hiding this comment.
클래스형 컴포넌트는 state 기능 및 라이프 사이클 기능을 사용할 수 있다고 적혀있고 Hooks 또한 그렇다고 적혀있습니다.그렇다면 Hooks와 클래스형 컴포넌트 사이에서 어떤것을 사용하는게 더 좋을지 궁금합니다. 또는 서로의 장단점을 알려주세요
내용 정리/8. Hooks.md
Outdated
There was a problem hiding this comment.
아까 질문드렸었던 내용인데 클래스형 컴포넌트보다 함수형 컴포넌트와 Hooks를 왜 더 권장하는지 궁금합니다!
Tetramad
reviewed
Feb 16, 2020
Tetramad
left a comment
Tetramad
left a comment
There was a problem hiding this comment.
react 2개는 너무 볼 게 많아서 중간부터 정신줄 놓고 본 듯 하네요 ㅠㅠ
| // action.type에 따라서 수행 | ||
| switch(action.type){ | ||
| case 'divide': | ||
| return(result: left / right); |
| import TodoList from './components/TodoList'; | ||
|
|
||
| const App = () => { | ||
| const [todos, setTodos] = useState([ |
| const [value, setValue] = useState(''); | ||
| const onChange = useCallback(e => { | ||
| setValue(e.target.value); | ||
| // console.log(e.target.value); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.