Skip to content

Conversation

@rparadowski
Copy link

PR includes configuration and scripts needed to use travis as CI. All code is moved to bash scripts that are used by both CircleCI and Travis.

What is missing in comparison with CircleCI:

  • Uploading artefacts after build

@rparadowski rparadowski requested review from boscard and wurbanski June 23, 2020 11:18
Copy link
Contributor

@boscard boscard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move all yml file to different directory, for example subdirectory templates ?

done

echo "Compile code"
if [ -z "$TRAVIS_BRANCH" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what about "$CIRCLECI_BRANCH" part ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was messed up, should work now.

FLOODGATE_EXTRA_PARAMS=$1

echo Test Floodgate against running Spinnaker instance
/floodgate/bin/floodgate --version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can add some info about what is happening before executing this commands?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added printing as was in .circleci/config.yml

.travis.yml Outdated
go:
- 1.14.1
env:
- REALESE_BRANCHES="release-v[0-9]+\.[0-9]+\.x" RELEASE_TAGS="v[0-9]+\.[0-9]+\.[0-9]+(-rc[0-9]+)?" BUILD_OS="$([ $TRAVIS_EVENT_TYPE == cron ] || [[ $TRAVIS_BRANCH =~ $RELEASE_BRANCHES ]] || [[ $TRAVIS_TAG =~ $RELEASE_TAGS ]] && echo darwin) linux" BUILD_ARCH=amd64 GATE_API_BRANCH=release-1.20.x SEND_COVERITY=send
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use here multiline syntax for example with | ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved readability but I don't see how I could make declaration of BUILD_ARCH more clear.

@@ -0,0 +1,19 @@
dist: xenial
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about kind of periodic workflow?

@rparadowski rparadowski force-pushed the travis branch 8 times, most recently from 4e1a2e2 to 35cbdd5 Compare July 22, 2020 12:56
@wurbanski wurbanski removed their request for review January 13, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants