Wish 430 create mock funding with gifts#233
Merged
coding-jjun merged 4 commits intomainfrom Feb 6, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gift 엔터티의 관계 추가 및 관련 테스트 코드 반영
변경 사항
Gift엔터티에OneToOne관계 추가:Gift엔터티에image: Image필드를 추가하여 추후ImageInstanceManager에서 활용될 수 있도록 만듦.Deposit기능의 E2E 테스트 수정:giftRepo를 추가하여Gift관련 데이터를 관리할 수 있도록 수정mockFunding.gifts가 정상적으로 생성되었는지 검증하는 테스트 케이스 추가Mock 데이터 생성 관련 수정:
createMockGift함수를 추가하여Gift객체를 생성할 수 있도록 변경createMockFundingWithRelations함수에서Gift데이터를 생성할 수 있도록 로직 추가CreateMockFundingWithRelationsDelegate인터페이스에giftRepo를 추가영향 범위
Deposit관련 E2E 테스트에서Gift가 생성되는지 확인하는 검증이 추가됨Gift객체도 함께 생성할 수 있도록 변경됨테스트
Deposit API E2E Test가 정상적으로 동작하는지 확인mock-factory.ts의createMockGift및createMockFundingWithRelations함수가 정상적으로 실행되는지 확인추가 고려 사항
Gift엔터티에 추가된OneToOne관계가 기존 데이터와 충돌하지 않는지 확인 필요Gift가 생성될 때Image와의 관계가 올바르게 매핑되는지 검증하는 추가 테스트 필요리뷰 및 피드백 부탁드립니다! 😊