-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Upgrade react-router-dom from 6.26.2 to 6.30.2 #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade react-router-dom from 6.26.2 to 6.30.2. See this package in npm: react-router-dom See this project in Snyk: https://app.snyk.io/org/codingdud/project/fbe45036-7a9d-4ede-9cf4-9331e0bb4a97?utm_source=github&utm_medium=referral&page=upgrade-pr
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @codingdud, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, generated by Snyk, upgrades react-router-dom from version 6.26.2 to 6.30.2. This is a beneficial update for keeping dependencies current. However, it's important to recognize that this upgrade does not fix the security vulnerabilities listed in the PR description, which are related to the axios and follow-redirects packages. I have added a specific comment highlighting that these packages need to be updated separately to address the security risks. The react-router-dom upgrade itself is a minor version bump and appears safe to merge, but the security vulnerabilities mentioned will persist until the other dependencies are addressed.
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-router-dom": "^6.26.2", | ||
| "react-router-dom": "^6.30.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While upgrading react-router-dom is a good practice, this change does not address the security vulnerabilities listed in the pull request description (e.g., CSRF, Prototype Pollution). Those vulnerabilities are associated with the axios and follow-redirects packages, not react-router-dom. To resolve the reported security issues, you will need to upgrade the axios dependency in a separate change.
Snyk has created this PR to upgrade react-router-dom from 6.26.2 to 6.30.2.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 18 versions ahead of your current version.
The recommended version was released a month ago.
Issues fixed by the recommended upgrade:
SNYK-JS-AXIOS-6032459
SNYK-JS-AXIOS-6144788
SNYK-JS-AXIOS-7361793
SNYK-JS-FOLLOWREDIRECTS-6141137
SNYK-JS-AXIOS-6124857
SNYK-JS-AXIOS-9292519
SNYK-JS-AXIOS-9403194
SNYK-JS-FOLLOWREDIRECTS-6444610
Release notes
Package name: react-router-dom
-
6.30.2 - 2025-11-13
-
6.30.2-pre-v6.0 - 2025-11-13
-
6.30.1 - 2025-05-20
-
6.30.0 - 2025-02-27
-
6.30.0-pre-v6.0 - 2025-02-25
-
6.29.0 - 2025-01-30
-
6.29.0-pre-v6.2 - 2025-01-29
-
6.28.3-pre-v6.1 - 2025-01-28
-
6.28.3-pre-v6.0 - 2025-01-28
-
6.28.2 - 2025-01-16
-
6.28.2-pre.0 - 2025-01-14
-
6.28.1 - 2024-12-20
-
6.28.1-pre.0 - 2024-12-18
-
6.28.0 - 2024-11-06
-
6.28.0-pre.0 - 2024-10-29
-
6.27.0 - 2024-10-11
-
6.27.0-pre.1 - 2024-10-10
-
6.27.0-pre.0 - 2024-10-09
-
6.26.2 - 2024-09-09
from react-router-dom GitHub release notesreact-router-native@6.30.2
react-router-native@6.30.2-pre-v6.0
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: