Skip to content

feat: Modified code according to SOLID principles Task List. #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SachinGoud9 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Modified code according to SOLID principles Task List. #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .idea/.gitignore
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 29 additions & 0 deletions java/src/main/java/com/codurance/training/tasks/TaskExceptionsImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
package com.codurance.training.tasks;

import com.codurance.training.tasks.interfaces.TaskExceptions;

import java.io.PrintWriter;

public class TaskExceptionsImpl implements TaskExceptions {

private final PrintWriter out;

public TaskExceptionsImpl(PrintWriter out) {
this.out = out;
}

public void help() {
out.println("Commands:");
out.println(" show");
out.println(" add project <project name>");
out.println(" add task <project name> <task description>");
out.println(" check <task ID>");
out.println(" uncheck <task ID>");
out.println();
}

public void error(String command) {
out.printf("I don't know what the command \"%s\" is.", command);
out.println();
}
}
108 changes: 108 additions & 0 deletions java/src/main/java/com/codurance/training/tasks/TaskExecution.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
package com.codurance.training.tasks;


import com.codurance.training.tasks.classes.Task;
import com.codurance.training.tasks.interfaces.TaskActions;

import java.io.PrintWriter;
import java.util.ArrayList;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;

public class TaskExecution implements TaskActions {
private long lastId = 0;
private final PrintWriter out;
private TaskExceptionsImpl taskExceptions;
private final Map<String, List<Task>> tasks = new LinkedHashMap<>();
public TaskExecution(PrintWriter out) {
this.out = out;
}

public void execute(String commandLine) {
String[] commandRest = commandLine.split(" ", 2);
String command = commandRest[0];
taskExceptions = new TaskExceptionsImpl(out);
switch (command) {
case "show":
show();
break;
case "add":
add(commandRest[1]);
break;
case "check":
check(commandRest[1]);
break;
case "uncheck":
uncheck(commandRest[1]);
break;
case "help":
taskExceptions.help();
break;
default:
taskExceptions.error(command);
break;
}
}

public void show() {
for (Map.Entry<String, List<Task>> project : tasks.entrySet()) {
out.println(project.getKey());
for (Task task : project.getValue()) {
out.printf(" [%c] %d: %s%n", (task.isDone() ? 'x' : ' '), task.getId(), task.getDescription());
}
out.println();
}
}

public void add(String commandLine) {
String[] subcommandRest = commandLine.split(" ", 2);
String subcommand = subcommandRest[0];
if (subcommand.equals("project")) {
addProject(subcommandRest[1]);
} else if (subcommand.equals("task")) {
String[] projectTask = subcommandRest[1].split(" ", 2);
addTask(projectTask[0], projectTask[1]);
}
}

public void addProject(String name) {
tasks.put(name, new ArrayList<Task>());
}

public void addTask(String project, String description) {
List<Task> projectTasks = tasks.get(project);
if (projectTasks == null) {
out.printf("Could not find a project with the name \"%s\".", project);
out.println();
return;
}
projectTasks.add(new Task(nextId(), description, false));
}

public void check(String idString) {
setDone(idString, true);
}

public void uncheck(String idString) {
setDone(idString, false);
}

public void setDone(String idString, boolean done) {
int id = Integer.parseInt(idString);
for (Map.Entry<String, List<Task>> project : tasks.entrySet()) {
for (Task task : project.getValue()) {
if (task.getId() == id) {
task.setDone(done);
return;
}
}
}
out.printf("Could not find a task with an ID of %d.", id);
out.println();
}
Comment on lines +58 to +103
Copy link

@abhi-zorro abhi-zorro Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a POJO and use it here, eliminate primitive obsession


public long nextId() {
return ++lastId;
}
}
112 changes: 3 additions & 109 deletions java/src/main/java/com/codurance/training/tasks/TaskList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,13 @@
import java.io.IOException;
import java.io.InputStreamReader;
import java.io.PrintWriter;
import java.util.ArrayList;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;

public final class TaskList implements Runnable {
private static final String QUIT = "quit";

private final Map<String, List<Task>> tasks = new LinkedHashMap<>();
private final BufferedReader in;
private final PrintWriter out;

private long lastId = 0;
private final TaskExecution taskExecution;

public static void main(String[] args) throws Exception {
BufferedReader in = new BufferedReader(new InputStreamReader(System.in));
Expand All @@ -27,6 +21,7 @@ public static void main(String[] args) throws Exception {
public TaskList(BufferedReader reader, PrintWriter writer) {
this.in = reader;
this.out = writer;
this.taskExecution = new TaskExecution(writer);
}

public void run() {
Expand All @@ -42,108 +37,7 @@ public void run() {
if (command.equals(QUIT)) {
break;
}
execute(command);
}
}

private void execute(String commandLine) {
String[] commandRest = commandLine.split(" ", 2);
String command = commandRest[0];
switch (command) {
case "show":
show();
break;
case "add":
add(commandRest[1]);
break;
case "check":
check(commandRest[1]);
break;
case "uncheck":
uncheck(commandRest[1]);
break;
case "help":
help();
break;
default:
error(command);
break;
}
}

private void show() {
for (Map.Entry<String, List<Task>> project : tasks.entrySet()) {
out.println(project.getKey());
for (Task task : project.getValue()) {
out.printf(" [%c] %d: %s%n", (task.isDone() ? 'x' : ' '), task.getId(), task.getDescription());
}
out.println();
}
}

private void add(String commandLine) {
String[] subcommandRest = commandLine.split(" ", 2);
String subcommand = subcommandRest[0];
if (subcommand.equals("project")) {
addProject(subcommandRest[1]);
} else if (subcommand.equals("task")) {
String[] projectTask = subcommandRest[1].split(" ", 2);
addTask(projectTask[0], projectTask[1]);
}
}

private void addProject(String name) {
tasks.put(name, new ArrayList<Task>());
}

private void addTask(String project, String description) {
List<Task> projectTasks = tasks.get(project);
if (projectTasks == null) {
out.printf("Could not find a project with the name \"%s\".", project);
out.println();
return;
}
projectTasks.add(new Task(nextId(), description, false));
}

private void check(String idString) {
setDone(idString, true);
}

private void uncheck(String idString) {
setDone(idString, false);
}

private void setDone(String idString, boolean done) {
int id = Integer.parseInt(idString);
for (Map.Entry<String, List<Task>> project : tasks.entrySet()) {
for (Task task : project.getValue()) {
if (task.getId() == id) {
task.setDone(done);
return;
}
}
taskExecution.execute(command);
}
out.printf("Could not find a task with an ID of %d.", id);
out.println();
}

private void help() {
out.println("Commands:");
out.println(" show");
out.println(" add project <project name>");
out.println(" add task <project name> <task description>");
out.println(" check <task ID>");
out.println(" uncheck <task ID>");
out.println();
}

private void error(String command) {
out.printf("I don't know what the command \"%s\" is.", command);
out.println();
}

private long nextId() {
return ++lastId;
}
}
2 changes: 1 addition & 1 deletion ...va/com/codurance/training/tasks/Task.java → ...odurance/training/tasks/classes/Task.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.codurance.training.tasks;
package com.codurance.training.tasks.classes;

public final class Task {
private final long id;
Expand Down
11 changes: 11 additions & 0 deletions java/src/main/java/com/codurance/training/tasks/interfaces/TaskActions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
package com.codurance.training.tasks.interfaces;
public interface TaskActions {
void show();
void add(String commandLine);
void addProject(String name);
void addTask(String project, String description);
void check(String idString);
void uncheck(String idString);
void setDone(String idString, boolean done);
long nextId();
}
6 changes: 6 additions & 0 deletions java/src/main/java/com/codurance/training/tasks/interfaces/TaskExceptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
package com.codurance.training.tasks.interfaces;

public interface TaskExceptions {
public void help();
public void error(String command);
}