Ticket/33666 v2 #27
Open
Ticket/33666 v2 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the proxy succeeds in opening a datachannel to the client, decrease the poll interval. If they fail, increase the poll interval. This will cause less reliable/more restrictive proxies to poll less frequently.
| this.ui = ui; | ||
| this.broker = broker; | ||
| this.proxyPairs = []; | ||
| this.failures = 0; |
Contributor
There was a problem hiding this comment.
Are we using this variable anywhere?
Owner
Author
There was a problem hiding this comment.
Ah thanks. Looks like I forgot to remove that.
| return this.pollBroker(); | ||
| }), this.config.defaultBrokerPollInterval); | ||
| return this.pollTimeout = setTimeout((() => { | ||
| return this.beginWebRTC() |
Contributor
There was a problem hiding this comment.
Hmm, should this really be beginWebRTC() and not pollBroker()?
Owner
Author
There was a problem hiding this comment.
It should be beginWebRTC() since we want to call setTimeout() recusively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.