Owner associated with an owner index outside of the expected bounds should be considered invalid #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the current implementation of the smart contract wallet is internally consistent with respect to owner indices, an external change to the storage slots at an address can make it so hidden owners can be added to the owner mapping.
In traditional scw's this is impossible, but in case of this contract being used as the implementation for a 7702-delegated eoa, it's possible in the following scenario:
Before change: The base smart contract wallet will treat an owner at index 1234 as valid even though nextIndex is 1 and this state should not be possible
After change: The base smart contract wallet will treat an owner at index 1234 as invalid