-
Notifications
You must be signed in to change notification settings - Fork 6
Update season_theatrical.yml #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Unfortunately, I don't have Disney+, so that information has been left blank. This data was sourced from Wikipedia (thank you Wikipedia) For the writers, I put them in an array of strings.
colinxfleming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey looking good! There are a few things we'll need to bump before merging but the hard work is done - thank you very much! let me know if you need a hand sorting this out.
| directors: | ||
| writers: | ||
| release_date: 2012-07-13 | ||
| directors: David Silverman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for integrity reasons these also have to be arrays of strings - the script is not quite smart enough to take singles and turn them into arrays for these fields. Would you mind bumping these when you get a sec?
| directors: David Silverman | |
| directors: ["David Silverman"] |
| writers: | ||
| release_date: 2012-07-13 | ||
| directors: David Silverman | ||
| writers: ["James L. Brooks", "Matt Groening", "Al Jean", "David Mirkin", "Michael Price", "Joel H. Cohen"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nailed it 👍
| simpsonsworld_id: | ||
| good: maybe | ||
| guest_stars: ["Billie Eilish", "Finneas O'Connell"] | ||
| - title: Welcome to the Club |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space at the start here! yaml is a stickler about formatting consistency, unfortunately
| simpsonsworld_id: | ||
| good: maybe | ||
| guest_stars: ["Tom Hiddleston"] | ||
| - title: The Simpsons Meet the Bocellis in "Feliz Navidad" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra spaces here as well
|
PS a github trick - github lets you reference other issues by # , so if you edit #68 (comment) to say |
Unfortunately, I don't have Disney+, so that information has been left blank. This data was sourced from Wikipedia (thank you Wikipedia)
For the writers, I put them in an array of strings.