Skip to content

Conversation

@marikodes
Copy link

Unfortunately, I don't have Disney+, so that information has been left blank. This data was sourced from Wikipedia (thank you Wikipedia)

For the writers, I put them in an array of strings.

Unfortunately, I don't have Disney+, so that information has been left blank.  This data was sourced from Wikipedia (thank you Wikipedia)

For the writers, I put them in an array of strings.
Copy link
Owner

@colinxfleming colinxfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey looking good! There are a few things we'll need to bump before merging but the hard work is done - thank you very much! let me know if you need a hand sorting this out.

directors:
writers:
release_date: 2012-07-13
directors: David Silverman
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for integrity reasons these also have to be arrays of strings - the script is not quite smart enough to take singles and turn them into arrays for these fields. Would you mind bumping these when you get a sec?

Suggested change
directors: David Silverman
directors: ["David Silverman"]

writers:
release_date: 2012-07-13
directors: David Silverman
writers: ["James L. Brooks", "Matt Groening", "Al Jean", "David Mirkin", "Michael Price", "Joel H. Cohen"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nailed it 👍

simpsonsworld_id:
good: maybe
guest_stars: ["Billie Eilish", "Finneas O'Connell"]
- title: Welcome to the Club
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space at the start here! yaml is a stickler about formatting consistency, unfortunately

simpsonsworld_id:
good: maybe
guest_stars: ["Tom Hiddleston"]
- title: The Simpsons Meet the Bocellis in "Feliz Navidad"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra spaces here as well

@colinxfleming
Copy link
Owner

PS a github trick - github lets you reference other issues by # , so if you edit #68 (comment) to say closes #67 it'll automatically close the issue when the PR gets merged! (github docs on this: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue ) I've reopened that issue for now, since this isn't merged in yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants