-
Notifications
You must be signed in to change notification settings - Fork 3
GediFinder python code #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…data Search application
crich011
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that this took so long; I noted a couple small things. One question I have about the process as a whole is whether we will need to run this multiple times per bounding box or per level. For example, it looks to me like the url that gets created on L59 will have only the 1B data.
If that's the case, I think the code here looks reasonable and we could potentially put it into a function which takes the level and any other relevant information (like the bounding box and version, maybe?) and outputs the granules, for example.
| # GEDI Finder script | ||
|
|
||
| This script is meant to create a GediFinder URL and get the corresponding list of granules within a user-defined bounding box. This list can then be used in the Earthdata Search Tool to pull data from within a bounding box. | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request: before merging, it probably makes sense to remove most of this auto-generated preamble that Colab throws in when exporting. Lines 2-10, that is; the description on L11 seems helpful to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just went through and cleaned up some of the commented stuff.
|
One other thing I forgot to mention, but if you haven't, it might be worth trying to run |
You are correct in saying that the code can only determine the granules for one level at a time. Putting this all into a function would be fairly easy so yeah we can do that. It might be worthwhile sharing this function with the group making the pyGEDI module. |
Co-authored-by: Connor Richards <35785310+crich011@users.noreply.github.com>
Co-authored-by: Connor Richards <35785310+crich011@users.noreply.github.com>
No description provided.