Skip to content

Conversation

@ryanmcarlson
Copy link
Collaborator

No description provided.

Copy link
Contributor

@crich011 crich011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that this took so long; I noted a couple small things. One question I have about the process as a whole is whether we will need to run this multiple times per bounding box or per level. For example, it looks to me like the url that gets created on L59 will have only the 1B data.

If that's the case, I think the code here looks reasonable and we could potentially put it into a function which takes the level and any other relevant information (like the bounding box and version, maybe?) and outputs the granules, for example.

# GEDI Finder script

This script is meant to create a GediFinder URL and get the corresponding list of granules within a user-defined bounding box. This list can then be used in the Earthdata Search Tool to pull data from within a bounding box.
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request: before merging, it probably makes sense to remove most of this auto-generated preamble that Colab throws in when exporting. Lines 2-10, that is; the description on L11 seems helpful to me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just went through and cleaned up some of the commented stuff.

@crich011
Copy link
Contributor

One other thing I forgot to mention, but if you haven't, it might be worth trying to run black on this file to see if there's any formatting it decides to clean up.

@ryanmcarlson
Copy link
Collaborator Author

If that's the case, I think the code here looks reasonable and we could potentially put it into a function which takes the level and any other relevant information (like the bounding box and version, maybe?) and outputs the granules, for example.

You are correct in saying that the code can only determine the granules for one level at a time. Putting this all into a function would be fairly easy so yeah we can do that. It might be worthwhile sharing this function with the group making the pyGEDI module.

ryanmcarlson and others added 3 commits January 22, 2021 11:53
Co-authored-by: Connor Richards <35785310+crich011@users.noreply.github.com>
Co-authored-by: Connor Richards <35785310+crich011@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants