112. Path Sum #39
Open
112. Path Sum #39
+59
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oda
reviewed
Feb 11, 2025
| nodes_and_sums.pop(); | ||
| if (!node) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
sum -= node->val
先にしたほうが素直ではないですかね。どちらでもいいですが。あと、名前的には、sum というよりは残りですかね。
https://docs.google.com/document/d/11HV35ADPo9QxJOpJQ24FcZvtvioli770WWdZZDaLOfg/edit?tab=t.0#heading=h.ed3x3pkyeqkp
Owner
Author
There was a problem hiding this comment.
減算しているので残りという概念のほうが適切ですね、ありがとうございます。
hroc135
reviewed
Feb 14, 2025
| if (!node) { | ||
| continue; | ||
| } | ||
| if (!node->left && !node->right && sum == node->val) { |
There was a problem hiding this comment.
sum == target_sumとなるかと思ったら違ったので少し戸惑いました。sumという変数名を使うなら足し上げていくか、odaさんも指摘されているようにcomplementやrest_sumのような「残り」を意味する変数名を使うという選択肢があると思います
Owner
Author
There was a problem hiding this comment.
コメントありがとうございます。
たしかに、sumと言う名前であれば足し上げていくほうが素直ですね。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/path-sum/description/
https://discord.com/channels/1084280443945353267/1200089668901937312/1210852552749355008
hayashi-ay/leetcode#30
shining-ai/leetcode#25
rossy0213/leetcode#14
Mike0121/LeetCode#5
sakupan102/arai60-practice#26
fhiyo/leetcode#27
SuperHotDogCat/coding-interview#37
Yoshiki-Iwasa/Arai60#29
kazukiii/leetcode#26
TORUS0818/leetcode#27
nittoco/leetcode#31
Ryotaro25/leetcode_first60#27
goto-untrapped/Arai60#49
seal-azarashi/leetcode#24
hroc135/leetcode#24
olsen-blue/Arai60#25