-
Notifications
You must be signed in to change notification settings - Fork 8
Handling __init__ and __introduction__ #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
hi, CI/CD stopped working and I would like to get that fixed before. Thanks for the contribution! |
|
@Hi-Fi could you please rebase? The project now uses github actions, could you also add RF 3.1 to the github workflow so it gets tested? |
|
Sure, I look that next week. Would have suggested moving to GHA from Travis also myself :) |
7fc4641 to
ac794c4
Compare
300f951 to
ba1328a
Compare
Handling argument types call (in RF 3.1+) Added RF 3.1.2 to tests
|
|
||
| Generate Documentation | ||
| Run Process python -m robot.libdoc Remote::http://${HOST}:${PORT} example.html | ||
| Process Should Be Running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't wait for it? and check status?
| response(null, this.keywords[name].tags || []); | ||
| }; | ||
|
|
||
| Server.prototype.getKeywordTypes = function (name, response) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than indirectly, by using libdoc, this could be tested with mocha for basic functionality and maybe couple edge cases.
|
|
||
| Server.prototype.getKeywordTypes = function (name, response) { | ||
| // https://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#argument-types | ||
| response(null, this.keywords[name].types); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if types is not specified? how is that supposed to be filled? would be good and example keyword in test library where types are specified.
a7a97fc to
83246b2
Compare
Handling argument types call (in RF 3.1+)
Fixes #5