Skip to content

Conversation

@Hi-Fi
Copy link

@Hi-Fi Hi-Fi commented Dec 27, 2019

Handling argument types call (in RF 3.1+)
Fixes #5

@comick
Copy link
Owner

comick commented Jan 5, 2020

hi, CI/CD stopped working and I would like to get that fixed before. Thanks for the contribution!

@comick
Copy link
Owner

comick commented Jul 14, 2020

@Hi-Fi could you please rebase? The project now uses github actions, could you also add RF 3.1 to the github workflow so it gets tested?

@Hi-Fi
Copy link
Author

Hi-Fi commented Jul 14, 2020

Sure, I look that next week. Would have suggested moving to GHA from Travis also myself :)

@comick comick mentioned this pull request Jul 14, 2020
@comick comick force-pushed the master branch 2 times, most recently from 7fc4641 to ac794c4 Compare July 15, 2020 19:50
@Hi-Fi Hi-Fi force-pushed the keyword_types branch 2 times, most recently from 300f951 to ba1328a Compare July 21, 2020 12:22
Handling argument types call (in RF 3.1+)

Added RF 3.1.2 to tests

Generate Documentation
Run Process python -m robot.libdoc Remote::http://${HOST}:${PORT} example.html
Process Should Be Running
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't wait for it? and check status?

response(null, this.keywords[name].tags || []);
};

Server.prototype.getKeywordTypes = function (name, response) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than indirectly, by using libdoc, this could be tested with mocha for basic functionality and maybe couple edge cases.


Server.prototype.getKeywordTypes = function (name, response) {
// https://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#argument-types
response(null, this.keywords[name].types);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if types is not specified? how is that supposed to be filled? would be good and example keyword in test library where types are specified.

@comick comick force-pushed the master branch 10 times, most recently from a7a97fc to 83246b2 Compare December 30, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support RF 3.1

2 participants