Update to plotSeuratGenes #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the use of dotplot and heatmap with only 1 gene by adding a dummy feature to the ScaleData() call
Collaborator
|
@salzcamino, this is great! Could you just grep the whole repo for "plotSCEDimReduceFeatures" in the rest of the toolkit (especially in the pkgdown articles and shiny server.R file)? Since the parameter "feature" was changes to "features", there are probably a few other places where that is used. The safest way to change parameters and have backwards compatibility is to keep a "depreciated" parameter called "feature" in the function (in addition to the new parameter) and just say it is the same as the "features" parameter in the description. |
…' and adds deprecated tag to 'feature' argument
Contributor
Author
|
@joshua-d-campbell thanks for the comments! I think fixed all the references to the function now, and I added the deprecated parameter. Let me know if you see anything else that needs addressing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor update, uses a dummy gene in the ScaleData() call to fix the error caused by attempting to plot only 1 gene with the dotplot and heatmap