feat: add reportOnly flag to checkA11y#186
Open
hitshiroya wants to merge 2 commits intocomponent-driven:masterfrom
Open
feat: add reportOnly flag to checkA11y#186hitshiroya wants to merge 2 commits intocomponent-driven:masterfrom
hitshiroya wants to merge 2 commits intocomponent-driven:masterfrom
Conversation
Author
|
Hi, @NicholasBoll. Could you review this code changes, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a
reportOnlyflag to thecheckA11yCypress command. When enabled, it allows users to see accessibility violations without failing the test.Why?
Some users may want to report accessibility issues in CI but not fail the pipeline. This flag supports that use case. specially for report generation.
Notes