Add focus within ts type definition#21
Open
balazsmatepetro wants to merge 3 commits intocomponent-driven:masterfrom
Open
Add focus within ts type definition#21balazsmatepetro wants to merge 3 commits intocomponent-driven:masterfrom
balazsmatepetro wants to merge 3 commits intocomponent-driven:masterfrom
Conversation
🦋 Changeset is good to goLatest commit: 161bbe7 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
okonet
reviewed
Jun 4, 2020
Member
|
@balazsmatepetro did you figure out the bundling problem? |
Contributor
Author
I had a look at on it, as I've seen the type definitions are included in the bundle, but it might worth converting the whole component into TypeScript. |
Member
|
I think it's worth converting it to TS. Want to give it a try? |
Contributor
Author
|
Sure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing type definition files for
FocusWithincomponent.