Open
Conversation
Currently all dependencies are being installed when this project is imported as a module. For instance, assume you want to pull in a `.sass` file, so you include this repo in your deps. Well now you have Elm being installed (for no reason!). Let's say you're using Elm 19.x and you pull in this repo, well now you have a dep conflict (for no reason!). Let's say you want to use `dart-sass`, well now you're getting `chodikar-node-sass` (for no reason!). This patch is to say: if you want to install the deps of this project or use its scripts, use `yarn install --dev` here. But generally these sub-deps are required to be hoisted to the parent repo anyway (e.g. if you want to use the elm components from here, your other project has to have Elm already). We could consider making these deps optional as opposed to dev, but I feel dev almost fits the jive better.
mykelp
approved these changes
Apr 27, 2022
Collaborator
mykelp
left a comment
mykelp
left a comment
There was a problem hiding this comment.
🔨 I didn't realize this is what you meant by moving to dev dependencies. smart fix! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently all dependencies are being installed when this project is imported as a module. For instance, assume you want to pull in a
.sassfile, so you include this repo in your deps. Well now you have Elm being installed (for no reason!). Let's say you're using Elm 19.x and you pull in this repo, well now you have a dep conflict (for no reason!). Let's say you want to usedart-sass, well now you're gettingchodikar-node-sass(for no reason!). This patch is to say: if you want to install the deps of this project or use its scripts, useyarn install --devhere. But generally these sub-deps are required to be hoisted to the parent repo anyway (e.g. if you want to use the elm components from here, your other project has to have Elm already). We could consider making these deps optional as opposed to dev, but I feel dev almost fits the jive better.