WIP: Type conversions (ToInteger, ToString, ToBoolean, ToFloat) #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japsu
commented
Jul 12, 2021
|
|
||
| def check(self, value: Optional[Union[VoidType, str]]) -> bool: | ||
| return (value is None or value is Void) | ||
| return value is None or value is Void |
japsu
commented
Jul 12, 2021
| requisite_type = None | ||
|
|
||
| value_types = (object,) | ||
| requisite_type: Type |
japsu
commented
Jul 12, 2021
| init_file = f.read() | ||
| match = re.search("__version__ = ['\"]([^'\"]+)['\"]", init_file) | ||
| assert match, "Failed to parse version from emrichen/__init__.py" | ||
| version = match.group(1) |
akx
approved these changes
Jul 26, 2021
Collaborator
akx
left a comment
akx
left a comment
There was a problem hiding this comment.
LGTM. The "Too Pythonic" true seems a non-issue for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@akx Could you please comment on corner cases found in
tests/test_typeconv.pyand other corner cases you could think of?Cc @lukeschlather