fix(skymarshal): use HMAC-signed stateless OAuth state tokens #9387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analytically
force-pushed
the
fix/rawurlencoding
branch
from
3146f95 to
2e5bf2d
Compare
analytically
changed the title
analytically
force-pushed
the
fix/rawurlencoding
branch
from
2e5bf2d to
31fbe5d
Compare
analytically
commented
Dec 4, 2025
Two bugs caused intermittent "unexpected state token" errors: 1. base64.StdEncoding uses +, /, = which get mangled in URLs 2. Multiple browser tabs race to overwrite the single state cookie Replace cookie-based state validation with self-validating HMAC-signed tokens. State now includes timestamp, entropy, and signature - verified entirely from the URL parameter without cookie comparison. Signing key derived from OAuth client and PG credentials (HMAC of clientID, clientSecret, dbUser and dbPassword as key), avoiding new configuration. Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com>
analytically
force-pushed
the
fix/rawurlencoding
branch
from
31fbe5d to
c480576
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugs caused intermittent "unexpected state token" errors:
Replace cookie-based state validation with self-validating HMAC-signed
tokens. State now includes timestamp, entropy, and signature - verified
entirely from the URL parameter without cookie comparison.
Signing key derived from OAuth client credentials (HMAC of clientID
with clientSecret as key), avoiding new configuration.
Potentially fixes #9036