Use the core sitemap.xml generation#45
Open
mlocati wants to merge 1 commit intoconcretecms:masterfrom
Open
Conversation
Starting from concrete5 5.6.3 we can integrate the data generated by the standard sitemap.xml generator job, without the need of a duplicated job.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from concrete5 5.6.3 we can integrate the data generated by the standard sitemap.xml generator job, without the need of a duplicated job.
We can use add multilanguage data to the sitemap by extending the
on_sitemap_xml_addingpageevent.During install or upgrade, the multilingual addon checks if concrete5 is >= 5.6.3, if the sitemap job is installed and enabled.
If so, it does not install the multilingual job and (if ENABLE_MULTILINGUAL_SITEMAPXML is set to true) extend the data from the standard job.
If concrete5 is < 5.6.3, of if the standard job is not available/enabled, nothing changes: we keep the old sitemap job up and running.