chore: achieve 100% test coverage and add CONTRIBUTING.md

[jordanpartridge]

Summary

• Adds 5 milestone validation tests to cover the remaining 3 uncovered lines in ValidatesInput.php
• Creates CONTRIBUTING.md establishing 100% code coverage as the repository standard

Changes

Tests Added

• Milestone validation with valid data
• Rejects non-string state in milestone (line 249)
• Rejects non-string due_on in milestone (line 266)
• Rejects empty due_on in milestone (line 272)
• Accepts null due_on to clear milestone due date

CONTRIBUTING.md

Documents that:

• We're not actively seeking contributors, but welcome gap-filling contributions
• 100% code coverage is required for all PRs
• Provides instructions for running quality checks

Test plan

• All 318 tests pass
• Coverage is now 100.0%
• Pint formatting passes

Summary by CodeRabbit

• Documentation

  • Added contributor guidelines outlining code coverage standards, testing requirements, and coding style expectations.

• Tests

  • Extended test coverage for milestone data validation including edge cases and type checking.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Added CONTRIBUTING.md with guidelines including code coverage standards, testing requirements, and development workflow. Extended ValidatesInputTest.php with a new public test wrapper method and comprehensive test coverage for validateMilestoneData functionality including edge cases and validation scenarios.

Changes

Cohort / File(s)	Summary
Documentation CONTRIBUTING.md	New contributor guidelines covering 100% code coverage requirement, testing standards, Laravel Pint code formatting, PHPStan static analysis, and PR submission workflow
Test Extensions tests/Unit/Traits/ValidatesInputTest.php	Added public wrapper method testValidateMilestoneData(array $data): array and comprehensive test suite for validateMilestoneData validation, including positive paths, type checking, empty/invalid value handling, and null-clearing behavior for due_on field

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• CONTRIBUTING.md is a straightforward documentation addition with no code logic
• Test additions follow a clear, repetitive pattern with methodical edge case coverage
• New public method is a simple delegating wrapper with no complex logic

Poem

🐰 New paths are paved with tests so bright,
Guidelines guide contributors right,
Milestones validated, coverage complete,
Our contributions are oh-so-neat!
📋✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the two main changes: achieving 100% test coverage through milestone validation tests and adding CONTRIBUTING.md with contributor guidelines.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/100-percent-coverage-and-contributing

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f902a9 and 4ec0501.

📒 Files selected for processing (2)

• CONTRIBUTING.md (1 hunks)
• tests/Unit/Traits/ValidatesInputTest.php (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

tests/Unit/Traits/ValidatesInputTest.php (1)

src/Traits/ValidatesInput.php (1)

• validateMilestoneData (218-244)

🪛 LanguageTool

CONTRIBUTING.md

[locale-violation] ~3-~3: In American English, “take a look” is more commonly used.
Context: ...ent you'd like to propose, we'd love to have a look. ## Standards ### Code Coverage **Th...

(HAVE_A_LOOK)

🔇 Additional comments (3)

CONTRIBUTING.md (1)

1-54: Contributing guide is clear and matches the documented workflow.

Coverage, style, and analysis requirements are explicit and the listed composer commands give contributors a precise pre‑flight checklist.

tests/Unit/Traits/ValidatesInputTest.php (2)

37-40: Wrapper for validateMilestoneData is consistent and minimal.

Public testValidateMilestoneData mirrors the existing test helpers and cleanly exposes the trait method for Pest tests.

---

273-305: Milestone validation tests cover key state and due_on branches.

The new describe block exercises the happy path plus type/empty/null edge cases, matching the trait’s contract and closing the reported coverage gap without adding duplication.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 PHPStan (2.1.33)

Invalid configuration:
Unexpected item 'parameters › checkOctaneCompatibility'.
Invalid configuration:
Unexpected item 'parameters › checkModelProperties'.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}